Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.97.0 #5849

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Release 1.97.0 #5849

merged 6 commits into from
Jun 9, 2023

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Jun 9, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.97.0

Related PRs

Changes

Display lock icon in disabled state of Cell component

Upgrade compile and target sdk version to Android API 33

Fix dictation regression, in which typing/dictating at the same time caused content loss.

VideoPress- Show "No title"/"No description" placeholder for not belonged videos

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@jhnstn jhnstn mentioned this pull request Jun 9, 2023
Merged
This was referenced Jun 9, 2023
Merged
Merged
@jhnstn jhnstn marked this pull request as ready for review June 9, 2023 15:23
@jhnstn jhnstn enabled auto-merge June 9, 2023 16:45
dcalhoun
dcalhoun reviewed Jun 9, 2023
View reviewed changes
gutenberg Show resolved Hide resolved
@jhnstn jhnstn requested a review from dcalhoun June 9, 2023 17:48
@jhnstn jhnstn disabled auto-merge June 9, 2023 17:49
@jhnstn jhnstn merged commit 89bec9f into trunk Jun 9, 2023
@jhnstn jhnstn deleted the release/1.97.0 branch June 9, 2023 20:12
@jhnstn
Copy link
Member Author

jhnstn commented Jun 14, 2023 •
edited
Loading

🟢 Writing Flow checklist (iOS)

Build: 22.6.0.0
Device: iPhone SE iOS 16.11

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@jhnstn
Copy link
Member Author

jhnstn commented Jun 14, 2023 •
edited
Loading

🟢 Unsupported Block Tests (iOS)

Build: 22.6.0.0
Device: iPhone SE iOS 16.11

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jhnstn
Copy link
Member Author

jhnstn commented Jun 14, 2023 •
edited
Loading

⚪ Included Changes (iOS)

Build: 22.6.0.0
Device: iPhone SE iOS 16.11

@jhnstn
Copy link
Member Author

jhnstn commented Jun 14, 2023 •
edited
Loading

⚪ Functionality Tests - Suite 3 (iOS)

Build: 22.6.0.0
Device: iPhone SE iOS 16.11

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 3

  • Gallery block - Settings: Link to - TC012
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 1

  • Columns - Check if in DarkMode all components gets proper colors - TC018

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - TC001

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC004
  • Cover - Replace media - TC005
  • Cover - Gradient background is rendered properly - TC006
  • Cover - Gradient overlay is rendered properly - TC007

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@fluiddot
Copy link
Contributor

fluiddot commented Jun 14, 2023 •
edited
Loading

🟢 Writing Flow checklist (Android)

Build: 22.6-rc-1
Device: Samsung Galaxy S20 FE 5G

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot
Copy link
Contributor

fluiddot commented Jun 14, 2023 •
edited
Loading

⚠️ Included Changes (Android)

Build: 22.6-rc-1
Device: Samsung Galaxy S20 FE 5G

@fluiddot
Copy link
Contributor

fluiddot commented Jun 14, 2023 •
edited
Loading

🟢 Functionality Tests - Suite 2 (Android)

Build: 22.6-rc-1
Device: Samsung Galaxy S20 FE 5G

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - Deep nesting is possible (verify iOS does not crash) - TC001
  • Group - Check if Group placeholder is visible for the unselected state - TC002
  • Group - Check if Group placeholder is render in nested structure - TC003
  • Group - Nested block have proper border styling - TC004
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC005

Buttons-1

  • Buttons block - Button's wrapper grows properly - TC019
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC002
  • Buttons block - Wrapping Buttons - TC003

Button-2

  • Buttons block - Buttons alignment options - TC004
  • Buttons block - Settings: Open in new tab - TC007
  • Buttons block - Settings: Link rel - TC008

Button-3

  • Buttons block - Settings: Link URL - TC006
  • Buttons block - Settings: Remove link - TC010
  • Buttons block - Settings: Synchronize with button options - TC009

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

Drag and Drop Blocks - 1

  • Drag and Drop Blocks - Drag block to the top of the content - TC001
  • Drag and Drop Blocks - Drag block to the bottom of the content - TC002

VideoPress - 2

  • VideoPress block - Player - TC003
  • VideoPress block - Private video - TC005
  • VideoPress block - Upload limit for Free users - TC006

@fluiddot
Copy link
Contributor

fluiddot commented Jun 14, 2023 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Build: 22.6-rc-1
Device: Samsung Galaxy S20 FE 5G

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

This was referenced Jun 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhnstn @fluiddot @dcalhoun