-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try a new hover and select approach to improve nested block selection #6773
Merged
Commits on May 30, 2018
-
Joen Asmussen committed
May 30, 2018 Configuration menu - View commit details
-
Copy full SHA for 44ca18f - Browse repository at this point
Copy the full SHA 44ca18fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12be2f9 - Browse repository at this point
Copy the full SHA 12be2f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa2ea9f - Browse repository at this point
Copy the full SHA aa2ea9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62d412e - Browse repository at this point
Copy the full SHA 62d412eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d2ca61 - Browse repository at this point
Copy the full SHA 1d2ca61View commit details -
Configuration menu - View commit details
-
Copy full SHA for a31b30d - Browse repository at this point
Copy the full SHA a31b30dView commit details -
Try a refined approach to drag and drop
This commit changes how drag and drop works, so that nested blocks do not have any invisible side affordance for the grabby handle. You can still use the inner padding for dragging, and in a separate enhancement we should make the hover label draggable. This makes it easier to select the parent block, by allowing you to click the available space below the side UI to select the parent. Kinda. There is still an affordance for hovering the side of the block to access the side UI (movers, settings, trash), and this extends the height of 4 stacked buttons on the side. If you hover the area below that, yes you can click the thing below. This is a balancing act, and I'd like for you to try this. The branch has been thoroughly rebased and squashed prior to this to make it easy to undo this change if it doesn't feel right.
Joen Asmussen committedMay 30, 2018 Configuration menu - View commit details
-
Copy full SHA for 7488a96 - Browse repository at this point
Copy the full SHA 7488a96View commit details -
Fix the empty appender in more than columns block
The empty appender, when on mobile, or in a nested block, shows a reduced version. Previously this was only in the columns block, now it's any block that uses nested children.
Joen Asmussen committedMay 30, 2018 Configuration menu - View commit details
-
Copy full SHA for 696ce2f - Browse repository at this point
Copy the full SHA 696ce2fView commit details -
Joen Asmussen committed
May 30, 2018 Configuration menu - View commit details
-
Copy full SHA for feaa3f0 - Browse repository at this point
Copy the full SHA feaa3f0View commit details -
Joen Asmussen committed
May 30, 2018 Configuration menu - View commit details
-
Copy full SHA for 9bb97aa - Browse repository at this point
Copy the full SHA 9bb97aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f527cf4 - Browse repository at this point
Copy the full SHA f527cf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e12ea7 - Browse repository at this point
Copy the full SHA 8e12ea7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bcec0f - Browse repository at this point
Copy the full SHA 3bcec0fView commit details
Commits on Jun 1, 2018
-
Add border to switcher component instead. Add comment to explain z index.
Joen Asmussen committedJun 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 29e1792 - Browse repository at this point
Copy the full SHA 29e1792View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.