Fix draghandle color #9948
Merged
Fix draghandle color #9948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes design nitpick from #9569 (comment).
youknowriad
reviewed
Sep 17, 2018
| @@ -93,6 +93,7 @@ | |||
| .editor-block-mover__control-drag-handle { | |||
| cursor: move; // Fallback for IE/Edge < 14 | |||
| cursor: grab; | |||
| fill: currentColor; | |||
There was a problem hiding this comment.
Some people asked about "dark theme" support for the drag handle, will this fix it?
There was a problem hiding this comment.
Can you clarify "dark theme" support? Because there's one issue for providing an actual dark theme for Gutenberg.
But yes, if paired with add_theme_support( 'dark-editor-style' ); and a dark editor style, this handle would be inverted.
There was a problem hiding this comment.
Yes, I believe it's about add_theme_support( 'dark-editor-style' ); I just saw this here https://wordpress.slack.com/archives/C02QB2JS7/p1537090223000100
mcsf
pushed a commit
that referenced
this pull request
Sep 21, 2018
Fixes design nitpick from #9569 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes design nitpick from #9569 (comment).
Before:
After: