Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix draghandle color #9948

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Fix draghandle color #9948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/editor/src/components/block-mover/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
.editor-block-mover__control-drag-handle {
cursor: move; // Fallback for IE/Edge < 14
cursor: grab;
fill: currentColor;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some people asked about "dark theme" support for the drag handle, will this fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify "dark theme" support? Because there's one issue for providing an actual dark theme for Gutenberg.

But yes, if paired with add_theme_support( 'dark-editor-style' ); and a dark editor style, this handle would be inverted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe it's about add_theme_support( 'dark-editor-style' ); I just saw this here https://wordpress.slack.com/archives/C02QB2JS7/p1537090223000100


&,
&:not(:disabled):not([aria-disabled="true"]):not(.is-default):hover,
Expand Down