Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Dart 2.13.4 as the primary SDK version for dev and CI #356

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

todbachman-wf
Copy link
Member

Problem:

Currently we treat Dart 2.7.2 as our primary SDK target when running CI. At Workiva, we're transitioning to Dart 2.13.4 as our primary version for development. Perhaps we should treat it as our primary target in CI.

Solution:

  • Updated Dockerfile to use the google/dart:2.13.4 image.
  • Updated dart_ci.yaml to explicitly run on Dart 2.13.4 and make sure we're checking formatting on that version of the SDK.
    • I left 2.7.2 in the test matrix since we technically still support older versions of Dart.

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@todbachman-wf
Copy link
Member Author

QA +1
@Workiva/release-management-pp

@rmconsole6-wk rmconsole6-wk merged commit 62992eb into master Sep 9, 2021
Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk deleted the update_to_dart_2.13_in_ci branch September 9, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants