Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat Dart 2.13.4 as the primary SDK version for dev and CI #356

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Treat Dart 2.13.4 as the primary SDK version for dev and CI #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/dart_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [ 2.7.2, stable, dev ]
sdk: [ 2.7.2, 2.13.4, stable, dev ]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/[email protected]
Expand Down Expand Up @@ -46,6 +46,8 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: dart-lang/[email protected]
with:
sdk: 2.13.4

- name: Print Dart SDK version
run: dart --version
Expand All @@ -55,9 +57,9 @@ jobs:
run: pub get

- name: Verify formatting
run: pub run dart_dev format --check
run: dart run dart_dev format --check
if: always() && steps.install.outcome == 'success'

- name: Publish dry run
run: pub publish --dry-run
run: dart pub publish --dry-run
if: always() && steps.install.outcome == 'success'
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [3.6.7](https://github.com/Workiva/dart_dev/compare/3.6.7...3.6.6)

- Treat Dart 2.13.4 as the primary Dart SDK for development and CI.

## [3.6.6](https://github.com/Workiva/dart_dev/compare/3.6.6...3.6.5)

- Only use build_runner to run tests if the package has direct dependencies on
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM google/dart:2.7
FROM google/dart:2.13.4
WORKDIR /build
ADD pubspec.yaml /build
RUN pub get
Expand Down