Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Windows compatibility #386

Merged
merged 6 commits into from
Aug 26, 2022
Merged

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Aug 18, 2022

There are several paths that we're using in our executable and in the run script that we generate and we need to construct them with the appropriate APIs from package:path to ensure they work when running on Windows. This PR does that.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@autobot-wk
Copy link

Skynet test results failed initially for this build but were approved by evan.weible
https://wf-skynet-hrd.appspot.com/apps/test/smithy/3860935/1
Approval message: Known failures on alpha and beta.

@evanweible-wf evanweible-wf changed the title Use join() from package:path for Windows compatibility Fixes for Windows compatibility Aug 26, 2022
@evanweible-wf evanweible-wf marked this pull request as ready for review August 26, 2022 20:34
@autobot-wf
Copy link

Skynet test results failed initially for this build but were approved by evan.weible
https://wf-skynet-hrd.appspot.com/apps/test/smithy/3863889/1
Approval message: Known failures on beta and alpha.

@evanweible-wf
Copy link
Contributor Author

QA +1

  • Had a Windows user manually verify that this fixes the issue with the generated run script.
  • CI passes on stable, which now includes running the entire test suite on Windows.

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants