-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Windows compatibility #386
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Skynet test results failed initially for this build but were approved by evan.weible |
join()
from package:path
for Windows compatibility9f88919
to
720be36
Compare
adf4367
to
4bda0cf
Compare
Skynet test results failed initially for this build but were approved by evan.weible |
QA +1
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
There are several paths that we're using in our executable and in the run script that we generate and we need to construct them with the appropriate APIs from
package:path
to ensure they work when running on Windows. This PR does that.