Fixes for Windows compatibility (backpatch to 3.7.x) #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
evanweible-wf
changed the title
join() from package:path for Windows compatibility (backpatch to 3.7.x)|
|
||
| test('configFromRunScriptForDart', () { | ||
| expect(paths.configFromRunScriptForDart, | ||
| r'../../tool/dart_dev/config.dart'); |
There was a problem hiding this comment.
Are the path separators for a relative path really not backslashes in windows? If so, how inconsistent.
There was a problem hiding this comment.
Turns out this is a path that will be used as an import in a .dart file. Dart always uses forward slashes regardless of the platform. So, nothing to do here.
todbachman-wf
approved these changes
Aug 26, 2022
|
QA +1
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several paths that we're using in our executable and in the run script that we generate and we need to construct them with the appropriate APIs from
package:pathto ensure they work when running on Windows. This PR does that.