Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with tracy_client #15

Closed
cwfitzgerald opened this issue May 25, 2022 · 4 comments · Fixed by #35
Closed

Integration with tracy_client #15

cwfitzgerald opened this issue May 25, 2022 · 4 comments · Fixed by #35
Labels
help wanted Extra attention is needed

Comments

@cwfitzgerald
Copy link
Contributor

Now that tracy has proper C api support for GPU timestamps, it would be a great extension to this library to offer a tracy feature where the timestamps collected by wgpu-profiler are reported to tracy.

I am planning on working on this in a while but I wanted to clear it with you before I did.

@Imberflur
Copy link
Collaborator

This would be very useful IMO. I assume this will involve addressing the implementation in tracy_client first nagisa/rust_tracy_client#19?

@cwfitzgerald
Copy link
Contributor Author

We shouldn't have to. That is basically an implementation of vulkan query set management like wgpu-profiler does. We just would need to build a simple rust interface to the __tracy_emit_gpu* functions in tracy_client and then bind to that from here.

Just depends on nagisa/rust_tracy_client#39 (which I see you've already saw)

I actually think I might hack on this tomorrow.

@Imberflur
Copy link
Collaborator

We just would need to build a simple rust interface to the __tracy_emit_gpu* functions in tracy_client and then bind to that from here.

Oh, I assumed this is what the issue I linked meant (i.e. exposing this simple interface at the tracy_client level).

@cwfitzgerald
Copy link
Contributor Author

Yeah that issue is for the actual implementation on top of vulkan, like tracy has natively for all the apis.

@Wumpf Wumpf added the help wanted Extra attention is needed label Mar 3, 2023
@Wumpf Wumpf closed this as completed in #35 Aug 2, 2023
nagisa pushed a commit to nagisa/rust_tracy_client that referenced this issue Aug 13, 2023
Depends on #39

Context Wumpf/wgpu-profiler#15

This adds the GPU api to tracy_client. It merely adds safe interfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants