-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a feature for memory tracing with tracy #8272
Conversation
does this fix #6927? |
I tried this a while back. For whatever reason, it broke logging due to registering a logger/subscriber before logging initialization in @hymm I think this only partially helps with monitoring memory usage and allocator usage (which we should be minimizing), but it doesn't let have detailed snapshots of memory to find what is using too much memory. |
Another view showing all allocation events happening during a span, here
At least a very good first step. @james7132 ? |
Maybe that has been fixed now, at least logging doesn't seem broken for me. |
Oh definitely, this is still great.. Though I would really like a Chrome-like support for labeled allocations to more readily dive into the exact split of memory usage at a given time.
Great. LGTM then. |
On Linux I think there are probably better tools (bytehound for profiling and heaptrack for the visualization is excellent in my experience), but this will probably be the best we can do for Windows (existing Windows tools either don't work with Rust, or they don't give any real insight into the application's allocations other than the total amount allocated). If anyone has an Intel CPU then it might be worth comparing this to VTune. As a side note, I don't think we can use Tracy's GPU profiling unless someone can take over and finish nagisa/rust_tracy_client#41, then integrate it with wgpu-profiler (and then it would be limited to backends that support |
out of curiosity, did you see a huge slowdown from enabling the memory tracing? On my project I have to keep it off because it's too slow |
Yup! The lighting example went from 500fps to 90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not going to block on it, but we should have something for how to use the feature in profiling.md
.
Objective