Slove the bug when salting peaks overlap #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the environment is messy, the event can overlap with multiple salting peaks. Then we will see errors like:
This is because
strax._fully_contained_in
(which is used bystrax.split_by_containment
inEventBasics
) will only return the first container of things. Sostrax.split_by_containment
will return zero peaks in the event even if the peaks belong to the event, when events are duplicated.