Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when triggering peak in an event is not from the salting peaks #74

Merged
merged 2 commits into from
May 13, 2024

Conversation

dachengx
Copy link
Collaborator

Following #73

In some very rare cases, the events will overlap with multiple salting peaks. So the triggering peak in an event might not be from the salting peaks but from other salting peaks. In these cases, the salting peaks are not triggering events, but theirs1_salting_number or s2_salting_number can be not -1, but we need to remove them from the definition of "triggering".

@coveralls
Copy link

coveralls commented May 13, 2024

Pull Request Test Coverage Report for Build 9060912996

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.401%

Changes Missing Coverage Covered Lines Changed/Added Lines %
axidence/plugins/cuts/cuts_event_building.py 2 4 50.0%
Totals Coverage Status
Change from base Build 9056332051: 0.0%
Covered Lines: 692
Relevant Lines: 1373

💛 - Coveralls

@dachengx dachengx marked this pull request as ready for review May 13, 2024 10:02
@dachengx dachengx merged commit 62fcab1 into main May 13, 2024
5 checks passed
@dachengx dachengx deleted the main_peak_trigger branch May 13, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants