SplitHTTP: Fix wrong config deserialization #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing was conducted only using explicit parameters, and using
testsuite. However, when the parameters are not explicitly set in JSON
config, it seems that `c.MaxUploadSize` will contain `RandRangeConfig {
From: 0, To: 0 }` instead of `nil`, which breaks upload entirely.
|
想把 maxUploadSize 改名为 改成 maxEachUploadBytes |
|
改成 maxEachUploadBytes |
|
Maybe like this? |
|
@Fangliding you're right, this seems to just be a case of wrong types in the json struct... since this works for now, i will fix it properly later, once the dust settles. thanks |
没问题的话我就先发 v1.8.23 了， |
|
1.8.23 can be released, nothing can go wrong. the order.. ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual testing was conducted only using explicitly set parameters. However, when the parameters are not explicitly set in JSON config, it seems that
c.MaxUploadSizewill containRandRangeConfig { From: 0, To: 0 }instead ofnil, which breaks upload entirely.I now tested all combinations and can confirm that h1, h2, h3 work fine against both new and old servers.