SplitHTTP: Rename maxUploadSize to maxUploadBytes, reduce server defaults #3611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感觉 Upload 还是不够精准，全改为 Post：
|
|
|
|
|
|
|
|
I don't have good ideas here. Instead of I suggest that the parameters are actually not renamed and only the defaults are fixed. |
|
我还是同意mmm的 更何况还是已发布的版本已经有的字段 有的修改为了兼容甚至要拖到下下个版本 但是一个config字段却要直接break(btw 我个人觉得这个协议还在beta阶段 break一下很正常 不用把有的改动还拖到下下个版本) |
按这个改吧，sc 代表 sub-connection |
主要是 ok 那种协议交互的不好改， |
|
093558b 这个尾部也加上 Ms 吧 |
|
Ms改名部（） |
mmmray
force-pushed
the
splithttp-new-new-defaults
branch
from
093558b
to
eb064c9
Compare
|
准备好了后给我说 |
|
yeah it's ready |
mmmray
added a commit
to mmmray/Xray-core
that referenced
this pull request
Aug 16, 2024
Since XTLS#3603 and XTLS#3611, iperf and speedtest are triggering "too large upload" by the server. This is because v2ray's MultiBuffer pipe can actually return data larger than the configured size limit. I'm surprised nobody noticed it so far. In principle, any heavy upload could disrupt the entire connection. In its infinite wisdom, speedtest.net hides such errors and only shows low upload instead. I only noticed this issue myself when inspecting server logs.
mmmray
added a commit
to mmmray/Xray-core
that referenced
this pull request
Aug 16, 2024
Since XTLS#3603 and XTLS#3611, iperf and speedtest are triggering "too large upload" by the server. This is because v2ray's MultiBuffer pipe can actually return data larger than the configured size limit. I'm surprised nobody noticed it so far. In principle, any heavy upload could disrupt the entire connection. In its infinite wisdom, speedtest.net hides such errors and only shows low upload instead. I only noticed this issue myself when inspecting server logs.
mmmray
added a commit
to mmmray/Xray-core
that referenced
this pull request
Aug 16, 2024
Since XTLS#3603 and XTLS#3611, iperf and speedtest are triggering "too large upload" by the server. This is because v2ray's MultiBuffer pipe can actually return data larger than the configured size limit. I'm surprised nobody noticed it so far. In principle, any heavy upload could disrupt the entire connection. In its infinite wisdom, speedtest.net hides such errors and only shows low upload instead. I only noticed this issue myself when inspecting server logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3610 (comment)