Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

fix: scanner.next() won't automatically recover when server side not return ERR_OK #86

Merged
merged 8 commits into from
May 8, 2021

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer marked this pull request as ready for review April 29, 2021 06:53
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #86 (bb86d7e) into master (50cb769) will increase coverage by 2.19%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   68.75%   70.95%   +2.19%     
==========================================
  Files          19       19              
  Lines        1277     1284       +7     
==========================================
+ Hits          878      911      +33     
+ Misses        355      331      -24     
+ Partials       44       42       -2     
Impacted Files Coverage Δ
pegasus/scanner.go 87.23% <92.85%> (+11.11%) ⬆️
session/session.go 86.33% <0.00%> (+1.24%) ⬆️
pegasus/table_connector.go 86.45% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50cb769...bb86d7e. Read the comment docs.

@neverchanje
Copy link

LGTM. But you should still need to add a test before merging this PR.

@foreverneverer foreverneverer marked this pull request as draft April 29, 2021 08:25
@foreverneverer foreverneverer marked this pull request as ready for review April 29, 2021 13:11
@Smityz
Copy link
Contributor

Smityz commented May 8, 2021

What's the meaning of batchUnknownError?

@foreverneverer
Copy link
Contributor Author

foreverneverer commented May 8, 2021

What's the meaning of batchUnknownError?

any unhandler error,such as rpc success but rocksdb report un-handle error

@hycdong
Copy link
Contributor

hycdong commented May 8, 2021

What's the meaning of batchUnknownError?

any unhandler error,such as rpc success but rocksdb report un-handle error

batchUnknownError makes me confused too, I suggest that you can add comments for it.

@foreverneverer
Copy link
Contributor Author

What's the meaning of batchUnknownError?

any unhandler error,such as rpc success but rocksdb report un-handle error

batchUnknownError makes me confused too, I suggest that you can add comments for it.

@hycdong done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants