Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go-client): scan will not recover when encounter error_invalid_state #1106

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Aug 8, 2022

What problem does this PR solve?

#903

If rpc's resp = error_invalid_state, go client should support re-config, which support most api but not scan in the past

What is changed and how does it work?

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
Code changes
  • Has interface methods change
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@b27f101). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1106   +/-   ##
=========================================
  Coverage          ?   53.40%           
=========================================
  Files             ?       27           
  Lines             ?     2522           
  Branches          ?        0           
=========================================
  Hits              ?     1347           
  Misses            ?     1130           
  Partials          ?       45           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@foreverneverer foreverneverer marked this pull request as ready for review August 8, 2022 06:37
@foreverneverer foreverneverer merged commit 6ceb51b into apache:master Aug 8, 2022
@empiredan empiredan mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants