Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum libc version from 0.2 to 0.2.100 #57

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Mar 5, 2024

Fixes tests using cargo +nightly update -Z minimal-versions to verify that things work with the minimal dependency version, such as loom is doing.

The minimal version could be lower (the driver is the si_addr() method on siginfo_t), but already 0.2.100 is so old that we do not need to go further back.

Fixes tests using `cargo +nightly update -Z minimal-versions` to verify
that things work with the minimal dependency version, such as `loom` is
doing.

The minimal version could be lower (the driver is the `si_addr()` method
on `siginfo_t`), but already 0.2.100 is so old that we do not need to go
further back.
@fornwall
Copy link
Contributor Author

fornwall commented Mar 5, 2024

CI failure in loom that is the driver here: tokio-rs/loom#338

@Xudong-Huang Xudong-Huang merged commit 3e74afc into Xudong-Huang:master Mar 6, 2024
9 checks passed
@fornwall
Copy link
Contributor Author

fornwall commented Mar 6, 2024

@Xudong-Huang Thanks! If possible it would be nice to release a 0.8.1 patch release with this to enable it's inclusion in loom.

@fornwall fornwall deleted the minimum-libc-version branch March 6, 2024 07:37
@Xudong-Huang
Copy link
Owner

sure, now 0.8.1 crate is released

@fornwall
Copy link
Contributor Author

fornwall commented Mar 6, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants