Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generator to 0.8.1 #338

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Update generator to 0.8.1 #338

merged 1 commit into from
Mar 6, 2024

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Mar 5, 2024 •
edited by Darksonn
Loading

Closes: #337

This was referenced Mar 5, 2024
Open
Merged
@fornwall
Copy link
Contributor Author

fornwall commented Mar 5, 2024 •
edited
Loading

The minimal dependency versions check is failing due to generator stating libc version 0.2 as the minimal version, but does not actually build against a libc version that old.

Proposed bumping that for generator here: Xudong-Huang/generator-rs#57

@fornwall fornwall changed the title Update generator to 0.8 Update generator to 0.8.1 Mar 6, 2024
@fornwall
Copy link
Contributor Author

fornwall commented Mar 6, 2024

Proposed bumping that for generator here: Xudong-Huang/generator-rs#57

This has now been merged and released as generator version 0.8.1. I've bumped to that, and this PR should now be ready.

taiki-e
taiki-e approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 2d5f2f3 into tokio-rs:master Mar 6, 2024
5 checks passed
@torokati44
Copy link

It would be nice to get a new release with this in. Not important, just to help clean up some transitive dependency version duplications of downstream projects. 😇

@Darksonn
Copy link
Contributor

Done in #348.

@torokati44
Copy link

Thank you! ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade generator to 0.8
4 participants
@fornwall @torokati44 @Darksonn @taiki-e