Proposal: switch to shorter names for MotoROS2 binaries #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ted-miller: this uses That's different from what we currently use for the micro ( |
This will help loading these binaries on older controllers, such as the DX200, while still being reasonably clear as to what controller series and ROS 2 version are supported by each file.
Naming convention: mr2_<controller>_<ros2_codename>.
Where 'mr2' is the abbreviated application name ('MotoROS2').
And where <controller> is the abbreviated name of the controller series: 'fs' (FS100), 'dx2' (DX200), 'yrc1' (YRC1000) and 'yrc1m' (YRC1000micro).
And where <ros2_codename> is the first letter of the ROS 2 codename: 'f' (Foxy), 'g' (Galactic), 'h' (Humble), etc.
gavanderhoorn
force-pushed
the
shorter_binary_names
branch
from
84e57bf
to
85b9f62
Compare
ted-miller
approved these changes
Aug 3, 2023
I'll rebase #49 and add the missing changes there. We need to review the readme and other files for missing DX200 references a final time anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is in f44a537: it updates the VS project to change the names of the
.outfiles to their shorter alternatives as discussed in #107.See the commit comment for the naming scheme used.
The second commit updates the readme to refer to the binaries by their new names.