Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing troubleshooting items #151

Merged
merged 9 commits into from
Sep 21, 2023
Merged

Add missing troubleshooting items #151

merged 9 commits into from
Sep 21, 2023

Conversation

ted-miller
Copy link
Collaborator

Fixes #141

@ted-miller ted-miller added this to the 0.1.2 milestone Sep 14, 2023
Copy link
Collaborator

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round of comments.

doc/troubleshooting.md Outdated Show resolved Hide resolved
doc/troubleshooting.md Outdated Show resolved Hide resolved
doc/troubleshooting.md Outdated Show resolved Hide resolved
doc/troubleshooting.md Show resolved Hide resolved
doc/troubleshooting.md Outdated Show resolved Hide resolved
doc/troubleshooting.md Outdated Show resolved Hide resolved
doc/troubleshooting.md Show resolved Hide resolved
doc/troubleshooting.md Outdated Show resolved Hide resolved
@gavanderhoorn
Copy link
Collaborator

@ted-miller: I've added some commits to polish a few things.

@ted-miller
Copy link
Collaborator Author

ted-miller commented Sep 19, 2023

I'm fine with the edits you made.

Copy link
Collaborator

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me like this 👍

@gavanderhoorn
Copy link
Collaborator

Wrong button :/

feel free to merge @ted-miller.

@gavanderhoorn
Copy link
Collaborator

Might want to use a squash-merge to prevent all the fixups from getting into the history.

@gavanderhoorn gavanderhoorn merged commit 59d564c into main Sep 21, 2023
13 checks passed
@gavanderhoorn gavanderhoorn deleted the troubleshooting branch September 21, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing alarm subcodes in Troubleshooting
2 participants