-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for duplicated joint names in a trajectory #162
Conversation
Tested and working |
Actually: could you try rebasing on |
ignore that. |
Ok. Now I think it'll work |
I've rebased this branch to include the fix from #164. |
I can't test this right now, but you have. @ted-miller: could you maybe describe how you tested it? |
Using my FJT script, I duplicated the first axis joint name on the second axis. |
Co-authored-by: G.A. vd. Hoorn <[email protected]>
might want to check also with a joint at index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated version looks OK.
If you could test with repeated joint names at indices other than 0, this can be merged.
This comment was marked as off-topic.
This comment was marked as off-topic.
Tested again:
Client: control_msgs.action.FollowJointTrajectory_Result(error_code=-100214, error_string='The trajectory contains duplicate joint names.') Debug Log:
|
off-topic, but: what's up with the output of your debug logger? It's not supposed to look like that any more since #129 and some older PRs. |
I've got an old copy of the script in my home directory for convenience. I just haven't updated on my ubuntu machine. |
You could use a symlink and place it in |
Fixes #28
Not yet tested due to https://github.com/Yaskawa-Global/micro_ros_motoplus/issues/132