Avoid double timestamps in debug log output #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie: 'MON', 'TUE', etc. Makes the length of the stamp more predictable. And append 6 digits of the nanosecond part of the stamp instead of 3 (we have the resolution).
PR Yaskawa-Global#61 added a timestamp to the log message sent out by MotoROS2. Use that timestamp instead of calculating a new one upon reception. The format of the timestamp prefixed by MotoROS2 is exactly the same as what `debug_listener.py` used to prefix. But due to limitations on the VxWorks side, will likely not take time-zones into account.
So correct method name.
|
Tested on the YRC here. |
ted-miller
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96.
The debug logger script no longer prefixes the received-time to log lines, but instead extracts the sent-stamp from the message and prints that.
Note: on my YRC,
strftime(..)doesn't appear to take timezones into account -- or I haven't configured things correctly. This leads to a consistent 1 hour delta between time on my development PC and the controller, and consequently all log lines printed appear to be "from 1 hr in the past".