Bump ABCREV to receive fix for #1675 #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any reason to hold off merging this? |
Typically I wait for the OP to double-check that it does indeed fix it for them. In particular for this case, I didn't bother with the original big testcase but just used the ABC result. |
|
FWIW someone on IRC reported that bumping ABC did fix it for them, and then Dave looked up the relevant code change, that's how I came to post the link to that commit. It wasn't the OP of the issue, but it's some confirmation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1675 by pulling in upstream fix.
Specific ABC testcase provided in #1675 now passes with
yosys-abc, and the result also passes ABC's own combinational equivalence checkcec.