Added RecursiveCharacterSplitter #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found the description on LangChain website and created my implementation, seems to be working. It will split documents recursively by different characters - starting with "\n\n", then "\n", then " ". This is nice because it will try to keep all the semantically relevant content in the same place for as long as possible. Orig from langchain: https://js.langchain.com/docs/modules/indexes/text_splitters/examples/recursive_character
|
Hi! Let me know if I need to do anything for this PR to be submitted |
|
Hi @LexiestLeszek looks like there was one test failure, but it may resolve itself with re-run. Doing that now. |
|
I am fairly new to commiting to public libraries and don't understand what happend. How can I help? |
|
@LexiestLeszek Nothing is needed from your end, just that github's machines don't have enough processing power to run the kind of benchmarks that we can run locally. I just reduced the processing time for one of the tests, so it should be ok to merge once the tests complete now. |
ZachNagengast
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the description on LangChain website and created my implementation, seems to be working. It will split documents recursively by different characters - starting with "\n\n", then "\n", then " ". This is nice because it will try to keep all the semantically relevant content in the same place for as long as possible.
Orig from langchain: https://js.langchain.com/docs/modules/indexes/text_splitters/examples/recursive_character