Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RecursiveCharacterSplitter #14

Merged
merged 2 commits into from
Jul 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
//
// RecursiveCharacterSplitter.swift
//
// Created by Leszek Mielnikow on 03/07/2023.
//

import Foundation
import SimilaritySearchKit

public class RecursiveCharacterSplitter: TextSplitterProtocol {
let characterSplitter: CharacterSplitter

public init() {
characterSplitter = CharacterSplitter()
}

public func split(text: String, chunkSize: Int = 100, overlapSize: Int = 0) -> ([String], [[String]]?) {
let separators = ["\n\n", "\n", ".", " "]

for separator in separators {
let splits = text.components(separatedBy: separator)
let (isValid, splitTokens) = isSplitValid(chunks: splits, maxChunkSize: chunkSize)

if isValid {
var chunks: [String] = []
var chunkTokens: [[String]] = []

var currentChunkTokens: [String] = []
var currentChunkSize: Int = 0
var currentChunkSplit: String = ""

for (idx, tokens) in splitTokens.enumerated() {
let tokensSize = tokens.count

if currentChunkSize + tokensSize < chunkSize {
currentChunkTokens.append(contentsOf: tokens)
currentChunkSize += tokensSize
currentChunkSplit += splits[idx] + separator

} else {
chunks.append(currentChunkSplit.trimmingCharacters(in: .whitespaces))
chunkTokens.append(characterSplitter.split(text: currentChunkSplit, chunkSize: chunkSize).0)

// reset current
currentChunkTokens = tokens
currentChunkSize = tokensSize
currentChunkSplit = splits[idx] + separator
}
}

// Add the last chunk if it's not empty
if !currentChunkSplit.isEmpty {
chunks.append(currentChunkSplit.trimmingCharacters(in: .whitespaces))
chunkTokens.append(characterSplitter.split(text: currentChunkSplit, chunkSize: chunkSize).0)
}

return (chunks, chunkTokens)
}
}

return ([], [])
}

// MARK: - Helpers

private func isSplitValid(chunks: [String], maxChunkSize: Int) -> (Bool, [[String]]) {
var splitTokens: [[String]] = []

for chunk in chunks {
let tokens = characterSplitter.split(text: chunk, chunkSize: maxChunkSize).0
if chunk.count > maxChunkSize {
return (false, [])
}
splitTokens.append(tokens)
}

return (true, splitTokens)
}
}
2 changes: 1 addition & 1 deletion Tests/SimilaritySearchKitTests/BenchmarkTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class BenchmarkTests: XCTestCase {
}

func testDistilbertPerformanceSearch() {
let testAmount = 10
let testAmount = 2
let passageIds = Array(0..<testAmount).map { _ in UUID().uuidString }
let passageTexts = Array(MSMarco.passageTexts[0..<testAmount])
let passageUrls = MSMarco.passageUrls[0..<testAmount].map { url in ["source": url] }
Expand Down