2.6.4: Remove scope parameter from dependency node, hopefully fix mav…

…en-publish now for real
Zhuinden · Apr 21, 2022 · 4a297d7 · 4a297d7
1 parent 1934b6b
commit 4a297d7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,10 +1,12 @@
 # Change log
 
--Simple Stack 2.6.3 (2022-04-21)
+-Simple Stack 2.6.4 (2022-04-21)
 --------------------------------
 
 - FIX: Attempt at fixing a crash related to `LinkedHashMap.retainAll()` specifically on Android 6 and Android 6.1 devices (#256).
 
+- 2.6.3 had an issue with `maven-publish` and transitive dependencies were missing, and is therefore skipped.
+
 
 -Simple Stack 2.6.2 (2021-06-07)
 --------------------------------

diff --git a/README.md b/README.md
@@ -69,7 +69,7 @@ and then, add the dependency to your module's `build.gradle.kts` (or `build.grad
 
 ``` kotlin
 // build.gradle.kts
-implementation("com.github.Zhuinden:simple-stack:2.6.3")
+implementation("com.github.Zhuinden:simple-stack:2.6.4")
 
 implementation("com.github.Zhuinden.simple-stack-extensions:core-ktx:2.2.2")
 implementation("com.github.Zhuinden.simple-stack-extensions:fragments:2.2.2")
@@ -83,7 +83,7 @@ or
 
 ``` groovy
 // build.gradle
-implementation 'com.github.Zhuinden:simple-stack:2.6.3'
+implementation 'com.github.Zhuinden:simple-stack:2.6.4'
 
 implementation 'com.github.Zhuinden.simple-stack-extensions:core-ktx:2.2.2'
 implementation 'com.github.Zhuinden.simple-stack-extensions:fragments:2.2.2'

diff --git a/simple-stack/build.gradle.kts b/simple-stack/build.gradle.kts
@@ -75,7 +75,7 @@ afterEvaluate {
             register("mavenJava", MavenPublication::class) {
                 groupId = "com.github.Zhuinden"
                 artifactId = "simple-stack"
-                version = "2.6.3"
+                version = "2.6.4"
 
                 from(components["release"])
                 artifact(sourcesJar.get())
@@ -87,12 +87,12 @@ afterEvaluate {
 
                     configurationNames.forEach { configurationName ->
                         configurations[configurationName].allDependencies.forEach {
-                            if (it.group != null && it.version != "unspecified") {
+                            if (it.group != null) {
                                 val dependencyNode = dependenciesNode.appendNode("dependency")
                                 dependencyNode.appendNode("groupId", it.group)
                                 dependencyNode.appendNode("artifactId", it.name)
                                 dependencyNode.appendNode("version", it.version)
-                                dependencyNode.appendNode("scope", configurationName)
+                                //dependencyNode.appendNode("scope", configurationName)
                             }
                         }
                     }