Ignore double underscore properties #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @diffness! I think the npm tests are failing for the repo because of an outdated package. I'll have to get that fixed first before this gets merged |
|
Thanks @aarons22! Let me know if you need anything more from me. FYI, I've updated the PR to filter out any "all underscore" property, just in case they decide to add |
Fix startup errors #213 by ignoring __ items in getDeviceIds and getCommandIds.
Update filtering in `getDeviceIds` and `getCommandIds` to ignore any property whose name is entirely underscores. While it's probably unlikely a future Bond API update would add a triple underscore property (`___`), writing it this way instead of restricting to `_` and `__` seems more futureproof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #213 by ignoring __ items in getDeviceIds and getCommandIds.