Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore double underscore properties #216

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Ignore double underscore properties #216

merged 2 commits into from
Jul 15, 2022

Commits on Jul 15, 2022

  1. Ignore double underscore properties 

    Fix startup errors #213 by ignoring __ items in getDeviceIds and getCommandIds.
    @diffness @aarons22
    diffness authored and aarons22 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    18b9700 View commit details
    Browse the repository at this point in the history

  2. Ignore any property that is all underscores 

    Update filtering in `getDeviceIds` and `getCommandIds` to ignore any property whose name is entirely underscores. While it's probably unlikely a future Bond API update would add a triple underscore property (`___`), writing it this way instead of restricting to `_` and `__` seems more futureproof.
    @diffness @aarons22
    diffness authored and aarons22 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    d2cf114 View commit details
    Browse the repository at this point in the history