Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSW - Add primary weapon support #10284

Merged
merged 4 commits into from
Sep 8, 2024
Merged

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Sep 2, 2024

When merged this pull request will:

  • Title.

  • Prioritises launcher weapons over primary weapons, as you usually can't select CSW weapons.

  • Fix 2 "features":

    • If the loaded magazine had more than 1 round when disassembling and fit in the weapon returned, it would return the loaded ammo count - 1. I believe in practice this never happened, as only the CUP Metis supports being deployed as a weapon.
    • Not all compatible magazines were taken into account when getting vehicle magazines.
  • TODO: Add documentation

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/feature Release Notes: **ADDED:** label Sep 2, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Sep 2, 2024
@mrschick
Copy link
Contributor

mrschick commented Sep 3, 2024

Neat!
Some time ago I figured something like this could be a nice addition to the CSW component, related to the 3CB Faction's tripod-mounted PKM.

@johnb432 johnb432 merged commit 067f5f8 into master Sep 8, 2024
4 checks passed
@johnb432 johnb432 deleted the csw-add-primary-weapon-support branch September 8, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants