Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPE Compat - Add CSW support #10285

Merged
merged 18 commits into from
Sep 17, 2024
Merged

SPE Compat - Add CSW support #10285

merged 18 commits into from
Sep 17, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Sep 2, 2024

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/feature Release Notes: **ADDED:** label Sep 2, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Sep 2, 2024
@PabstMirror
Copy link
Contributor

I see some minor code style changes that could be made,
but I'm guessing we just want to make a few changes as possible from the original to make updating easier?

@johnb432
Copy link
Contributor Author

johnb432 commented Sep 6, 2024

I see some minor code style changes that could be made, but I'm guessing we just want to make a few changes as possible from the original to make updating easier?

I'm definitely not opposed to changing it.
I figured it would be "better" to stick as much to the original as possible, but I'm more than willing to update them to the ACE standard - I'll go ahead and do that.

@LinkIsGrim LinkIsGrim merged commit af6f969 into master Sep 17, 2024
8 checks passed
@LinkIsGrim LinkIsGrim deleted the compat-spe-csw branch September 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants