Implements ES2016 check for "use strict" #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ES2016, you can no longer have "use strict" in the body of a function that has complex parameters (destructured or using default values). Fixes acornjs#423
| @@ -9150,6 +9150,98 @@ test("function f([x] = [1]) {}", { | |||
| locations: true | |||
| }); | |||
|
|
|||
| test("function f([x] = [1]) { 'use strict' }", { | |||
There was a problem hiding this comment.
Added this test to make sure it still parses okay for ES6.
|
Is there anything else I need to do to land this? |
marijnh
added a commit
that referenced
this pull request
Jun 30, 2016
|
Nope, it looks good. I've merged it as a062434 and followed up with a small patch to remove the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ES2016, you can no longer have "use strict" in the body of a function
that has complex parameters (destructured or using default values).
Fixes #423