This repository has been archived by the owner on May 19, 2018. It is now read-only.
Implement ES2016 check for simple parameter list in strict mode #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See e.g. ECMA-262 7.0 14.1.2: > It is a Syntax Error if ContainsUseStrict of FunctionBody is true and > IsSimpleParameterList of FormalParameters is false. Similar clauses cover arrow functions, generator functions, methods, and generator methods, as well as async functions and async arrow functions.
|
The Travis CI failure is due to some tests in Babel copied from Traceur that were written for ES2015 only. Should I submit a PR to Babel that removes the tests first? |
|
@TimothyGu yeah sounds good |
|
@hzoo, PR to Babel submitted: babel/babel#4501 |
hzoo
pushed a commit
to babel/babel
that referenced
this pull request
Sep 12, 2016
These tests are originally from Traceur, which does not fully support ES2016. See babel/babylon#106 for a rationale why these code blocks are not valid ES2016.
Current coverage is 94.38% (diff: 100%)@@ master #106 diff @@
==========================================
Files 19 19
Lines 3130 3080 -50
Methods 320 325 +5
Messages 0 0
Branches 800 806 +6
==========================================
- Hits 3029 2907 -122
+ Misses 101 94 -7
- Partials 0 79 +79
|
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
These tests are originally from Traceur, which does not fully support ES2016. See babel/babylon#106 for a rationale why these code blocks are not valid ES2016.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per e.g. ECMA-262 7th Edition § 14.1.2:
Similar clauses cover arrow functions, methods, and generator functions/methods, as well as async functions and async arrow functions.
A similar change was merged in Acorn as acornjs/acorn#424, but instead of erroring out on the strict mode directive like that PR does I feel erroring out on the parameter is clearer.
The removed Esprima test case is still present in Esprima, but their support for ES2016 is incomplete anyway.