Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

598 preprocessor script for printing the library versions to boot outtxt #607

Merged
merged 1 commit into from
Oct 15, 2024
Merged

598 preprocessor script for printing the library versions to boot outtxt #607

merged 1 commit into from
Oct 15, 2024

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Jul 29, 2024

No description provided.

@tyeth tyeth linked an issue Jul 29, 2024 that may be closed by this pull request
Preprocessor script for printing the library versions to boot_out.txt #598
Closed
@tyeth tyeth mentioned this pull request Jul 30, 2024
Closed
@brentru
Copy link
Member

brentru commented Aug 20, 2024

@tyeth Is this ready for review?

@tyeth tyeth force-pushed the 598-preprocessor-script-for-printing-the-library-versions-to-boot_outtxt branch 4 times, most recently from f79aafe to b12572a Compare October 10, 2024 17:11
@tyeth tyeth marked this pull request as ready for review October 10, 2024 17:12
@tyeth tyeth mentioned this pull request Oct 10, 2024
Open
@tyeth
Copy link
Contributor Author

tyeth commented Oct 10, 2024

This should not be merged until the ci-wippersnapper branch for ci-arduino has been updated, as part of adafruit/ci-arduino#196, and this PR had the refs updated in the build script.
I probably need to resolve the conflict with the build file anyway.
Alternatively the current (598-blah) ref will work as it's ci-wippersnapper + print dependencies changes.

@tyeth tyeth requested a review from brentru October 10, 2024 17:28
@tyeth
Copy link
Contributor Author

tyeth commented Oct 10, 2024

@brentru this should be ready for review

brentru
brentru requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyeth Thanks for taking this on, its a simple approach. I do have some q's

.github/workflows/build-clang-doxy.yml Show resolved Hide resolved
.github/workflows/build-clang-doxy.yml Outdated Show resolved Hide resolved
.github/workflows/build-clang-doxy.yml Show resolved Hide resolved
src/print_dependencies.cpp Show resolved Hide resolved
src/provisioning/littlefs/WipperSnapper_LittleFS.cpp Show resolved Hide resolved
@tyeth tyeth force-pushed the 598-preprocessor-script-for-printing-the-library-versions-to-boot_outtxt branch from b12572a to 2ef6d72 Compare October 10, 2024 20:04
@tyeth tyeth merged commit e281576 into main Oct 15, 2024
35 checks passed
@tyeth tyeth deleted the 598-preprocessor-script-for-printing-the-library-versions-to-boot_outtxt branch October 22, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preprocessor script for printing the library versions to boot_out.txt
2 participants
@tyeth @brentru