Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wippersnapper preprocessor script for printing the library versions to boot outtxt #196

Open
wants to merge 9 commits into
base: ci-wippersnapper
Choose a base branch
from

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Oct 10, 2024

@brentru this is tied in with adafruit/Adafruit_Wippersnapper_Arduino#607

It adds a new flag to allow specifying the location of the header file to be generated/replaced --include_print_dependencies_header although now I've settled on not being able to modify the build flags I could probably pick a better name as it no longer adds an extra include to the build flags.

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyeth Requesting some changes and clarifications before I can merge

build_platform.py Outdated Show resolved Hide resolved
build_platform.py Outdated Show resolved Hide resolved
build_platform.py Outdated Show resolved Hide resolved
@tyeth tyeth requested a review from brentru October 22, 2024 19:06
@tyeth
Copy link
Contributor Author

tyeth commented Oct 24, 2024

@brentru this is ready for re-review. Hopefully this is resolved satisfactorily, I've acted on the great suggestions and added some context for the os.system change (use "show resolved")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants