Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/2876 JSX version of gmcq #124

Merged
merged 11 commits into from
Aug 27, 2021
Merged

issue/2876 JSX version of gmcq #124

merged 11 commits into from
Aug 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2020

@ghost ghost requested a review from oliverfoster August 24, 2020 14:47
js/gmcqView.js Outdated Show resolved Hide resolved
js/gmcqView.js Outdated Show resolved Hide resolved
js/gmcqModel.js Outdated Show resolved Hide resolved
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to pick up these amendments myself if needed.

templates/gmcq.jsx Outdated Show resolved Hide resolved
templates/gmcq.jsx Outdated Show resolved Hide resolved
templates/gmcq.jsx Outdated Show resolved Hide resolved
templates/gmcq.jsx Outdated Show resolved Hide resolved
@oliverfoster oliverfoster added the on hold do not merge label May 10, 2021
@oliverfoster
Copy link
Member

Ready to review, requires pr#3140

@oliverfoster oliverfoster added on hold do not merge and removed on hold do not merge labels Jun 7, 2021
@oliverfoster oliverfoster changed the title issue/2876 React version of gmcq issue/2876 JSX version of gmcq Aug 26, 2021
@oliverfoster oliverfoster self-assigned this Aug 26, 2021
@oliverfoster oliverfoster removed the on hold do not merge label Aug 26, 2021
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

templates/gmcq.jsx Outdated Show resolved Hide resolved
Co-authored-by: tomgreenfield <[email protected]>
Copy link

@ethan-lp ethan-lp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

@ethan-lp ethan-lp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 18ebba8 into master Aug 27, 2021
@oliverfoster oliverfoster deleted the issue/2876 branch August 27, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants