issue/2876 JSX version of graphic #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…converted hbs to jsx
ghost
requested a review
from 
|
@oliverfoster Not sure how to incorporate a11y_normalize in the aria-label, though, so I've left it out for now. |
oliverfoster
requested changes
Aug 18, 2020
There was a problem hiding this comment.
These changes make the component look much nicer.
And with this fw pr we'll be able to drop the reset on revisit stuff as well.
… a11y.normalize to jsx
|
@oliverfoster All changes made. Yeah, much easier to read like this--it'll make a real difference when the more involved hbs files are converted (like accordion). |
|
I've stolen some bits of styling from the way you've laid out this jsx for the accordion already. |
oliverfoster
approved these changes
Aug 18, 2020
jamesrea83
approved these changes
Aug 25, 2020
eleanor-heath
approved these changes
May 7, 2021
|
Ready to review, requires pr#3140 |
eleanor-heath
approved these changes
May 11, 2021
oliverfoster
changed the title
oliverfoster
requested review from
tomgreenfield,
cahirodoherty-learningpool and
eleanor-heath
and removed request for
tomgreenfield
eleanor-heath
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of adaptlearning/adapt_framework#2876