Skip to content

Commit

Permalink
Require at least Apache Maven 3.8.1 (#183)
Browse files Browse the repository at this point in the history
* Require at least Apache Maven 3.8.1

* Update docs

* Correct java version required
  • Loading branch information
cziegeler committed Jul 26, 2024
1 parent 1de9860 commit 4cbf747
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 8 deletions.
4 changes: 2 additions & 2 deletions aem-project-tool/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ governing permissions and limitations under the License.
<parent>
<groupId>com.adobe.aem</groupId>
<artifactId>parent-oss</artifactId>
<version>4</version>
<version>5-SNAPSHOT</version>
<relativePath>../parent-oss/pom.xml</relativePath>
</parent>

Expand Down Expand Up @@ -168,7 +168,7 @@ governing permissions and limitations under the License.
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>4.2.0</version>
<version>4.9.0</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
4 changes: 2 additions & 2 deletions aemanalyser-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ governing permissions and limitations under the License.
<parent>
<groupId>com.adobe.aem</groupId>
<artifactId>parent-oss</artifactId>
<version>4</version>
<version>5-SNAPSHOT</version>
<relativePath>../parent-oss/pom.xml</relativePath>
</parent>

Expand Down Expand Up @@ -91,7 +91,7 @@ governing permissions and limitations under the License.
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>4.2.0</version>
<version>4.9.0</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
2 changes: 2 additions & 0 deletions aemanalyser-maven-plugin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ A Maven plugin used by developers of applications for AEM as a Cloud Service (AE

The plugin provides an easy way to run the same checks locally as in the Cloud Manager pipeline and ensures that the application works correctly when deployed in the cloud.

This plugin requires at least Apache Maven 3.8.1 and Java version 11 or higher.

> **_NOTE:_** Please make sure to always use the latest version. Refrain from using any version below 1.1.10
## Functionality
Expand Down
6 changes: 3 additions & 3 deletions aemanalyser-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ governing permissions and limitations under the License.
<parent>
<groupId>com.adobe.aem</groupId>
<artifactId>parent-oss</artifactId>
<version>2</version>
<version>5-SNAPSHOT</version>
<relativePath>../parent-oss/pom.xml</relativePath>
</parent>

Expand All @@ -35,7 +35,7 @@ governing permissions and limitations under the License.
</scm>

<properties>
<maven.version>3.5.2</maven.version>
<maven.version>${maven.min.version}</maven.version>
</properties>

<prerequisites>
Expand Down Expand Up @@ -82,7 +82,7 @@ governing permissions and limitations under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-invoker-plugin</artifactId>
<version>3.2.2</version>
<version>3.3.0</version>
<configuration>
<projectsDirectory>src/it</projectsDirectory>
<cloneProjectsTo>${project.build.directory}/it</cloneProjectsTo>
Expand Down
3 changes: 2 additions & 1 deletion parent-oss/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ governing permissions and limitations under the License.
<!-- this is used for both enforcing the minimum java version and as compile target -->
<project.java.version>11</project.java.version>
<maven.plugin.tools.version>3.7.0</maven.plugin.tools.version>
<maven.min.version>3.8.1</maven.min.version>
<surefire.version>3.0.0-M7</surefire.version>
<maven.compiler.source>${project.java.version}</maven.compiler.source> <!-- affects m-compiler-p and m-javadoc-p -->
<maven.compiler.target>${project.java.version}</maven.compiler.target>
Expand Down Expand Up @@ -84,7 +85,7 @@ governing permissions and limitations under the License.
<configuration>
<rules>
<requireMavenVersion>
<version>[3.5.0,)</version>
<version>[${maven.min.version},)</version>
</requireMavenVersion>
<requireJavaVersion>
<version>${project.java.version}</version>
Expand Down

0 comments on commit 4cbf747

Please sign in to comment.