Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require at least Apache Maven 3.8.1 #183

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Require at least Apache Maven 3.8.1 #183

merged 4 commits into from
Jul 26, 2024

Conversation

cziegeler
Copy link
Contributor

With this change we require a more recent Apache Maven for building projects, 3.8.1. which is out since April 2021.

Description

Update the minimum Apache Maven version as well as the dependencies to the plugins and some other artifacts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@stefanseifert
Copy link
Contributor

afaik adobe cloud manager is still running with Maven 3.6.0

@cziegeler
Copy link
Contributor Author

@stefanseifert Thanks, that should be changed as well :)

jamiecounsell pushed a commit to jamiecounsell/aemanalyser-maven-plugin that referenced this pull request Dec 8, 2022
…rnings and speed up builds.

This will be replaced by a call to RemoteRepository.isBlocked() once adobe#183 is merged. This change sets the minumum Maven
version to 3.8.1 which will allow us to use verison 1.9 of the Maven Artifact Resolver API which has this method.

See: https://maven.apache.org/resolver/apidocs/org/eclipse/aether/repository/RemoteRepository.html#isBlocked()
@kwin
Copy link
Contributor

kwin commented May 26, 2023

Any ETA when Cloud Manager will be updated to a more recent Maven version (which is not 4.5 years old)?

@cziegeler
Copy link
Contributor Author

Cloud Manager has been updated to Apache Maven 3.8.8 end of 2023

@cziegeler cziegeler merged commit 950aa53 into main Jul 26, 2024
3 checks passed
@cziegeler cziegeler deleted the maven381 branch July 26, 2024 05:53
cziegeler added a commit that referenced this pull request Jul 26, 2024
* Require at least Apache Maven 3.8.1

* Update docs

* Correct java version required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants