Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Linux universal installer #316

Closed
wants to merge 13 commits into from
Closed

Linux universal installer #316

wants to merge 13 commits into from

Conversation

macie
Copy link

@macie macie commented Aug 26, 2013

Linux universal installer

  1. Structure of installer/linux/ dir:
    \ ..
    | - / <– distro specified files, eg. PKGBUILD, control
    | - /
    | - linux/ <– common files, eg. brackets.desktop
    | | - .INFO.template <– template (hidden) for INFO file
    | \ - INFO
    | - staging/ <– staging folder
    | - build_installer.sh
    | - _builder.sh
    \ - _builder.sh
  2. Description of files:
    • build_installer.sh – checks which distribution is currently used and starts _<distro_name>builder.sh
    • _<distro_name>builder.sh – builds distro-specified package inside <distro_name> directory
    • INFO – file with version number and other build-specified information. Generated by task/build.js
  3. Testing
    I check that 64-bit packages (for ubuntu and arch) builds without errors. I've successful instaled package for arch 64-bit and for ubuntu 64-bit (via https://aur.archlinux.org/packages/brackets/ script).
  4. Package naming convention
    I use "sprint30" as version number, but perhaps better would be full version number – "0.30.0-0"?

@jasonsanjose
Copy link
Member

Wow, thanks @macie for the contribution. The end of sprint 30 is coming up on Wednesday, so I probably won't have time to fully review and test this pull request by then. I'll make sure this is on our list for sprint 31.

@thefirstofthe300
Copy link

Agree with Jason. OMG, that is a lot of help.

@jasonsanjose
Copy link
Member

Tagged Sprint 31.

@ingorichter
Copy link
Contributor

That is a great contribution. Thank you. BTW: did anybody try to install on a 32Bit System?

@ghost ghost assigned jasonsanjose Aug 28, 2013
depends=("brackets-lib" "gconf" "nodejs" "nspr" "systemd")
makedepends=("prelink")
optdepends=(
"alsa-lib: <future use>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why asla-lib?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namcap says that some library from brackets (libcef.so if I remember) needs (optional) alsa support. Look at current debian package dependencies (libasound2).

@jasonsanjose
Copy link
Member

@macie I want to get a good grip on creating packages for arch linux. Is this https://wiki.archlinux.org/index.php/Creating_Packages a good resource or have you found others?

awk '{printf "%.0f\n", $1 / 1000}'`
# update control file
cd "package-root/DEBIAN"
awk -v arch=${ARCH} -v ver=${VERSION} -v size=${_SIZE} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of going back to awk since we ported our older shell scripts to Grunt. However, I understand how you've streamlined the workflow here, so I'm willing to compromise.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, interesting. When I wrote these scripts I think about future linux package makers, that they can create packages without knowledge of grunt. But is it right direction? Moving shell scripts to grunt seems to be much prettier. Bat files and mac shell scripts too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I don't think I care enough. 😄 This will be fine.

@jasonsanjose
Copy link
Member

Can we rename installer/linux/linux to installer/linux/common?

@jasonsanjose
Copy link
Member

@macie Initial review complete, but I haven't really reviewed the Arch packaging yet. I'm having some difficulties getting that setup. If you know someone else who is more familiar with Arch that can at least test your package and possibly review the PKGBUILD file, that would help.

@macie
Copy link
Author

macie commented Sep 9, 2013

@jasonsanjose building packages for arch linux is quite simple. It use makepkg command on PKGBUILD file.

Yes, installer/linux/common sounds better than installer/linux/linux.

PS. Apologize for my absence

@jasonsanjose
Copy link
Member

@macie thanks for the follow up. Please drop a comment for me here when you've pushed your changes. Please note that I'll be out on vacation starting the end of next week. If this pull request is still open @JeffryBooher will assist.

Also note that our sprint ends next Wednesday, September 19. Ideally we would like to land these changes sooner to get more testing.

@macie
Copy link
Author

macie commented Sep 12, 2013

@jasonsanjose Tomorrow I'll try to finish this pull request.

@jasonsanjose
Copy link
Member

Moved out of sprint 31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants