Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Code editor font makes me cry (with Russian / Cyrillic text) #3465

Closed
ixth opened this issue Apr 17, 2013 · 28 comments
Closed

Code editor font makes me cry (with Russian / Cyrillic text) #3465

ixth opened this issue Apr 17, 2013 · 28 comments

Comments

@ixth
Copy link

ixth commented Apr 17, 2013

Workaround: How to switch to a different code font


I have no 'SourceCodePro' and Russian text looks awfully in "MS ゴシック" and "MS Gothic" (which is default according to developer tools). Is there way to set custom font in editor view?

sprint 23 experimental build 0.23.0-6726 (master 6908b48), Windows7

2013-04-17_1227

@peterflynn
Copy link
Member

@ainop SourceCodePro is loaded from disk by Brackets using @font-face, so you do have it :-)

However, it looks like SourceCodePro doesn't support Cyrillic characters yet: adobe-fonts/source-code-pro#48. Feel free to comment on that issue so the font team knows you're interested!

In the meantime... there's no way in the Brackets UI to customize fonts yet. But if you're comfortable hacking the code a bit, you can edit www/styles/brackets_theme_default.less and change the .code-font rule. (There's no need to recompile or anything -- just re-launch Brackets). On Windows, Consolas would be a pretty good alternative font to try -- it's what Visual Studio uses, and Brackets used to use it before SourceCodePro went open-source.

@peterflynn
Copy link
Member

Adding 'tracking' tag since adobe-fonts/source-code-pro#48 covers the root issue. Clarifying issue title.

@njx
Copy link
Contributor

njx commented Apr 17, 2013

Should we consider adding Consolas as a fallback? If the Cyrillic glyphs aren't actually in Source Code Pro, maybe that would just work.

@njx
Copy link
Contributor

njx commented Apr 17, 2013

Also, @ainop, we're very sorry we made you cry!

@peterflynn
Copy link
Member

We'd have to be careful about what order Consolas vs. the Asian-language fonts go in since we still want fallback to work there too... but it might be doable. (And of course we'd need to pick an equivalent new fallback option for Mac... was it Lucida Console that we used to use?).

@njx
Copy link
Contributor

njx commented Apr 17, 2013

It looks like our Mac font fallback was Menlo, Monaco, monospace. (I think Monaco was in there for older versions of OS X that didn't have Menlo.)

@ixth
Copy link
Author

ixth commented Apr 18, 2013

Thanks a lot, guys! I'll patch my setup.

@ghost ghost assigned njx Apr 22, 2013
@njx
Copy link
Contributor

njx commented Apr 22, 2013

Reviewed. Medium priority to me. Might nominate it next sprint.

@romanov
Copy link

romanov commented Jul 16, 2013

Waiting for a great font.

@HamsterCoder
Copy link

Oh, my issue! =)
Russian characters are too far apart from eac other, so the whole code is not monospace anymore. I'll be waiting for a fix too.

@romanov
Copy link

romanov commented Aug 19, 2013

Current solution: https://github.com/adobe/brackets/wiki/Customize-Your-Code-Font
My recommendation for Windows users is font-family:Consolas, monospace;

untitled-1

@dananichev
Copy link
Contributor

How about selecting the font based on user's language? Atleast as default fonts for user.
My suggestion is
PT Sans
http://www.google.com/fonts/specimen/PT+Sans

@progreccor
Copy link

after installing new sprint i don't know where I can change russian font now?

@websanya
Copy link

@progreccor there is a great extension out there: https://github.com/tirithen/brackets-fonts, it provides a simple UI for changing fonts! ☕ PT Mono is pretty sweet.

btw, there is russian community for Brackets: http://vk.com/bracketsio

@romanov
Copy link

romanov commented Jan 20, 2014

@progreccor #3465 (comment) (updated)

@luzlol this extension does not support cyrillic (missing &subset=latin,cyrillic).

Source: https://github.com/adobe/brackets/wiki/Customize-Your-Code-Font

@websanya
Copy link

@romanov in fact it does, I've recorded a screencast for you =) http://www.youtube.com/watch?v=AOuBDLvoDgU

@njx
Copy link
Contributor

njx commented Apr 21, 2014

Update: it looks like Cyrillic and Greek support are underway for both Source Code Pro and Source Sans Pro. Here are the relevant issues: adobe-fonts/source-code-pro#48, adobe-fonts/source-sans#6. It looks like Source Sans Pro is done and will be shipping in the next update; not sure about Source Code Pro, but as of a month ago it looks like it was on its way as well.

@njx
Copy link
Contributor

njx commented Apr 21, 2014

(To clarify: Source Sans Pro is what we use in our UI; Source Code Pro is our editor font.)

@miguelsousa
Copy link
Member

@njx
Cyrillic and Greek support in Source Sans Pro is imminent.
At this point it's not clear when Source Code Pro will ship with the same level of language support.

@baursak
Copy link

baursak commented Jul 9, 2014

"Navigate to .CodeMirror and change font-family to any font with normal cyrillic support"
There are "110 matches" of ".CodeMirror" in file "[brackets folder]/www/styles/brackets.min.css"
Where do I have to "change font-family to any font with normal cyrillic support" ???

@romanov
Copy link

romanov commented Jul 9, 2014

@baursak 4th match:

.CodeMirror {
color:#535353;
font-size:12px;
line-height:1.25;
font-family:"SourceCodePro-Medium","MS ゴシック","MS Gothic",monospace
}

@baursak
Copy link

baursak commented Jul 9, 2014

Thanks. - Will keep it for 0.42 :) - In the meantime I have substituted all the "SourceCodePro" related phrases to "Consolas,monospace" (7 times in total). - It still works OK with Russian. - Great editor!

@peterflynn
Copy link
Member

@baursak @romanov Modifying your source code locally is fragile, and you'll have to redo it every time you upgrade Brackets. The workaround listed at the top of this page is much preferred: https://github.com/adobe/brackets/wiki/Customize-Your-Code-Font. (I'll edit the description to make it easier to spot).

@romanov Do you mind if I edit your post above to reduce the font size so it's not as prominent? We probably don't want to encourage people to use that approach too much.

Also note: in the very near future (release 0.42 or 0.43), you should be able to change your code editor font as a setting directly within the Brackets UI, without any hacks needed.

@baursak
Copy link

baursak commented Jul 10, 2014

Thank you! - Extension works.
OffTop. - Waiting for replies to:
#7638
#7497

@romanov
Copy link

romanov commented Jul 10, 2014

@peterflynn edited. Good news about the settings! Yes, the extension is better solution for now.

@abose
Copy link
Contributor

abose commented Jun 23, 2015

#11301 With latest source code pro addresses this issue.

@rawat11
Copy link

rawat11 commented Jun 30, 2015

@abose The latest ttf fonts displays the characters nicely.

Updating the SS for both MAC and WIn

1-russian-win
2-russian-win
5-russian-mac
6-russian-mac

@abose
Copy link
Contributor

abose commented Jun 30, 2015

Updated source code pro has support for Russian / Cyrillic text. Closing.
If certain glyphs are not rendered properly, raise another issue stating the details. Closing this issue now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

13 participants