This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix: Find in Files results don't update to reflect external changes unless file is open #11602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nless file is open
amrelnaggar
changed the title
|
Let me know if its accepted. I will stop working on it if thats the case. |
|
LGTM |
| @@ -795,7 +795,7 @@ define(function (require, exports, module) { | |||
|
|
|||
| var addPromise; | |||
| if (entry.isDirectory) { | |||
| if (!added || !removed) { | |||
| if (!added || !removed || (!added.length && !removed.length)) { | |||
There was a problem hiding this comment.
I'd personally prefer || (added.length === 0 && removed.length === 0))
Addresses code review comments
|
Made the changes, this was better indeed. |
|
Thanks @amrelnaggar ! |
This was referenced Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #10717 and covers all FileSystem change events