Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix: Find in Files results don't update to reflect external changes unless file is open #11602

Merged
merged 2 commits into from
Aug 27, 2016
Merged

Fix: Find in Files results don't update to reflect external changes unless file is open #11602

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b729799
Fix: Find in Files results don't update to reflect external changes u…
Aug 17, 2015
30bbf5f
Use strict equal of length of added and removed sets against zero
Aug 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/search/FindInFiles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ define(function (require, exports, module) {

var addPromise;
if (entry.isDirectory) {
if (!added || !removed) {
if (!added || !removed || (!added.length && !removed.length)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally prefer || (added.length === 0 && removed.length === 0))

// If the added or removed sets are null, must redo the search for the entire subtree - we
// don't know which child files/folders may have been added or removed.
_removeSearchResultsForEntry(entry);
Expand Down