-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template-registry
warning Generated an empty chunk
while rollup
#1067
Comments
Ah nice find. I think you're right. I was under the impression that only This isn't actually covered by the test suite though – since the template registry is only used by Glint's "loose mode" and the test-app is now in "strict mode". I don't really want to add a whole test app just to cover that 🤔 Do you have an Ember app running Glint in "loose" mode that you can test this with? Would prefer we check it now than find out through a bug report 😅 |
Unfortunately I don't have an app that has loose mode active... i have discoverd this only while other addon migration. I have seen that the addon-blueprint brings this line... so maybe this is a bug from blueprint.. i have for now created a issue in addon-blueprint (embroider-build/addon-blueprint#252)... maybe we wait for feedback and than we go on |
fix #1067 This is fixing a warning while rollup ../ember-file-upload prepare: [js] (!) Generated an empty chunk ../ember-file-upload prepare: [js] "template-registry"
…pted-ember-addons#1068) fix adopted-ember-addons#1067 This is fixing a warning while rollup ../ember-file-upload prepare: [js] (!) Generated an empty chunk ../ember-file-upload prepare: [js] "template-registry"
I have seen that there will exported
template-registry
as empty file:Last test run:
https://github.com/adopted-ember-addons/ember-file-upload/actions/runs/7606502732/job/20712414961#step:4:40
Edit: found this issue on addon blueprint embroider-build/addon-blueprint#195 (comment)
Edit 2: While working on a other addon i have found out, that line is not necessary and generates the empty file. we can remove it:
https://github.com/adopted-ember-addons/ember-file-upload/blob/master/ember-file-upload/rollup.config.mjs#L27
The text was updated successfully, but these errors were encountered: