Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary template-registry.js export in rollup.config.mjs #1068

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Feb 3, 2024

fix #1067

This is fixing a warning while rollup

../ember-file-upload prepare: [js] (!) Generated an empty chunk
../ember-file-upload prepare: [js] "template-registry"

@mkszepp mkszepp changed the title Remove unnecessary template-registry.js in rollup.config.mjs Remove unnecessary template-registry.js export in rollup.config.mjs Feb 3, 2024
@gilest gilest added the internal label Feb 8, 2024
@gilest
Copy link
Collaborator

gilest commented Feb 8, 2024

Ran pnpm pack locally and confirmed that

  • declarations/template-registry.d.ts is still present ✅
  • dist/template-registry.js is no longer present ✅
  • The last published package.json is unchanged ✅

On that basis I'm happy to merge this. Thanks for your contribution 🙂

@gilest gilest merged commit a22d599 into adopted-ember-addons:master Feb 8, 2024
14 checks passed
@mkszepp mkszepp deleted the remove-template-registry-export-in-public-entrypoints branch February 9, 2024 06:00
gvdp pushed a commit to Bagaar/ember-file-upload that referenced this pull request May 24, 2024
…pted-ember-addons#1068)

fix adopted-ember-addons#1067

This is fixing a warning while rollup

../ember-file-upload prepare: [js] (!) Generated an empty chunk
../ember-file-upload prepare: [js] "template-registry"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template-registry warning Generated an empty chunk while rollup
2 participants