-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added autoprefixer support for Safari >= 6 to use -webkit-flex #466
Conversation
Thanks! |
I was working @mmwebster on this bug, and can verify the bug. I think relying on the |
@mrinterweb @mmwebster how about we provide a reasonable default and allow users to configure that in their For the default, I'd like autoprefixer to support what ember supports: IE9+. Can I get your help to determine what the default value should be for autoprefixer? |
That sounds great. I'll get those changes together soon. |
@miguelcobain Sorry for wait, had a really busy week. I Added in the support for custom autoprefixer configs but had trouble finding specifics on Ember's browser support outside of IE9+. It just plugs in the autoprefixer option from the consuming app, so all you need is something like this in your ember-cli-build.js if you want to overwrite the default: |
The default seems to be |
Yea the default is |
For those curious, here's the current output of browserslist: $ browserslist 'last 2 versions'
chrome 52
chrome 51
edge 14
edge 13
firefox 48
firefox 47
ie 11
ie 10
ie_mob 11
ie_mob 10
ios_saf 9.3
ios_saf 9.0-9.2
opera 39
opera 38
safari 9.1
safari 9 $ browserslist 'last 3 versions'
chrome 52
chrome 51
chrome 50
edge 14
edge 13
edge 12
firefox 48
firefox 47
firefox 46
ie 11
ie 10
ie 9
ie_mob 11
ie_mob 10
ios_saf 9.3
ios_saf 9.0-9.2
ios_saf 8.1-8.4
opera 39
opera 38
opera 37
safari 9.1
safari 9
safari 8
|
Thanks again! |
My phone using ios safari 8.x works finally with { browsers: ['last 3 versions'] } |
@@ -132,7 +132,8 @@ module.exports = { | |||
|
|||
postprocessTree: function(type, tree) { | |||
if (type === 'all' || type === 'styles') { | |||
tree = autoprefixer(tree, { browsers: ['last 2 versions'] }); | |||
tree = autoprefixer(tree, | |||
this.app.options.autoprefixer || { browsers: ['last 2 versions'] }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it better to use last 3 versions instead of last 2 versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be more in favor of explicit browser support in the autoprefixer, rather than a rule that's interpretation changes as new browser versions are released. Possibly something like ['Chrome >= 50', 'Edge >= 12', 'ff >= 46', 'ie >= 9', 'ie_mob >= 10', 'ios_saf >= 8.1', 'Opera >= 37', 'Safari >= 8']
which is the translation of ['last 3 versions']
that @vine77 listed. This way dropping and adding support is done intentionally and doesn't cause any surprises down the road.
* commit '2cb9be5574a486175e48bc1a8da4186611f3ddbe': 1.0.0-alpha.4 update CHANGELOG allow inner dialog clicks to bubble. closes adopted-ember-addons#511 add ember resolution update ember-cli and fastboot call super remove Ember. property access update ember-cli to 2.8.0 make it glimmer 2 compatible WIP - remove other super calls Add super calls inside paper-input lifecycle hooks. update ember-css-transitions referencing the correct API (adopted-ember-addons#493) Match paper-sidenav demo width to [email protected] (adopted-ember-addons#482) Fix ripple artifact in Chrome 51 (adopted-ember-addons#475) update ember-css-transitions update CHANGELOG for adopted-ember-addons#466 update CHANGELOG for alpha.3 Added autoprefixer support for Safari >= 6 to use -webkit-flex (adopted-ember-addons#466)
The "last 2 versions" rule for the autoprefixer was not sufficient to add "display: -webkit-flex" support for Safari v8.0.6 and Safari in iOS Simulator v8.3. All Flexbox based features were broken as a result.