Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added autoprefixer support for Safari >= 6 to use -webkit-flex #466

Merged
merged 2 commits into from
Aug 24, 2016
Merged

Added autoprefixer support for Safari >= 6 to use -webkit-flex #466

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
790c885
Added autoprefixer support for Safari >= 6 to use -webkit-flex
mmwebster Aug 15, 2016
c1b6f68
Added support for custom autoprefixer config via consuming app's embe…
mmwebster Aug 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ module.exports = {

postprocessTree: function(type, tree) {
if (type === 'all' || type === 'styles') {
tree = autoprefixer(tree, { browsers: ['last 2 versions'] });
tree = autoprefixer(tree,
this.app.options.autoprefixer || { browsers: ['last 2 versions'] });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better to use last 3 versions instead of last 2 versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be more in favor of explicit browser support in the autoprefixer, rather than a rule that's interpretation changes as new browser versions are released. Possibly something like ['Chrome >= 50', 'Edge >= 12', 'ff >= 46', 'ie >= 9', 'ie_mob >= 10', 'ios_saf >= 8.1', 'Opera >= 37', 'Safari >= 8'] which is the translation of ['last 3 versions'] that @vine77 listed. This way dropping and adding support is done intentionally and doesn't cause any surprises down the road.

}
return tree;
},
Expand Down