Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk: update hotspot targets #5367

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Jun 4, 2024

This PR improves openjdk hotspot testing coverage ( see: #5316 ).

Changes:

  • hotspot_{compiler,gc,runtime,serviceability} were changed from jdk 8,9 to 11+, flagless configuration and moved to dev level (except for hotspot_compiler)
    • on jdk8 these groups actually only run sanity/ExecuteInternalVMTests.java (but on 8 almost all hotspot tests are ran by hotspot_jre target)
    • on jdk11+ these groups actually run tests in respective categories
  • new target hotspot_sanity - runs very basic sanity tests. (that's basically what disabled hotspot_* tests did on 8)
  • removed jdk_compiler - now replaced with hotspot_compiler (which now also corresponds to test group name in openjdk)
  • removed hotspot_serviceability_jvmti - not needed anymore, tests are included in hotspot_serviceability
  • renamed ASGCTBaseTest -> ASGCTBaseTest_j9 to indicate it is openj9 only (as in other openj9 targets)
  • renamed jvm_native_sanity -> hotspot_native_sanity (so that it corresponds to test group name in openjdk)

Testing:
So far tested only on x86-64_linux:

hotspot_sanity:
8: OK
11: OK
17: OK
21: OK

hotspot_compiler:
11: OK
17: OK
21: OK

hotspot_gc:
11: OK
17: OK
21: OK

hotspot_runtime:
11: OK
17: OK
21: 1 FAILURE
runtime/os/TestHugePageDecisionsAtVMStartup.java#THP_enabled.TestHugePageDecisionsAtVMStartup_THP_enabled
( could be missing support for old kernels (rhel-7) by THP code, see e.g.: JDK-8324580 )

hotspot_serviceability:
11: OK
17: OK
21: OK

@karianna karianna requested review from llxia and pshipton June 5, 2024 03:44
@llxia llxia requested a review from smlambert June 5, 2024 14:38
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes generally look fine, but I know that @zzambers wanted to run additional tests before merging, so I will put a hold until he is ready.

@zzambers
Copy link
Contributor Author

zzambers commented Jun 11, 2024

More testing:

x86-32_windows

hotspot_sanity:
8: OK
17: OK

hotspot_compiler:
11: OK
17: 1 FAILURE

compiler/arguments/CheckCICompilerCount.java.CheckCICompilerCount

hotspot_gc:
11: 2 FAILURES

gc/shenandoah/compiler/TestBarrierAboveProj.java
gc/shenandoah/jni/CriticalNativeStress.java

17: 1 FAILURE

gc/shenandoah/compiler/TestBarrierAboveProj.java

hotspot_runtime:
17: 2 FAILURES

runtime/cds/appcds/LambdaEagerInit.java.LambdaEagerInit
runtime/logging/loadLibraryTest/LoadLibraryTest.java.LoadLibraryTest

hotspot_serviceability:
17: 5 FAILURES

serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java.HeapMonitorStatArrayCorrectnessTest
serviceability/sa/CDSJMapClstats.java.CDSJMapClstats
serviceability/sa/ClhsdbFindPC.java#id0.ClhsdbFindPC_id0
serviceability/sa/ClhsdbFindPC.java#id1.ClhsdbFindPC_id1
serviceability/sa/ClhsdbJhisto.java.ClhsdbJhisto
serviceability/sa/ClhsdbJstackXcompStress.java.ClhsdbJstackXcompStress
serviceability/sa/ClhsdbJstack.java#id0.ClhsdbJstack_id0

@zzambers
Copy link
Contributor Author

ppc64_aix

hotspot_sanity:
17: OK

hotspot_runtime:
11: 2 FAILURES

runtime/NMT/HugeArenaTracking.java.HugeArenaTracking
runtime/jni/nativeStack/TestNativeStack.java.TestNativeStack

hotspot_serviceability:
17: 1 FAILURE

serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java.AttachReturnError

hotspot_gc:
17: OK

hotspot_compiler:
17: OK

@zzambers
Copy link
Contributor Author

zzambers commented Jun 18, 2024

x390x_linux

hotspot_serviceability:
17: 1 FAILURE

serviceability/dtrace/DTraceOptionsTest.java#enabled.DTraceOptionsTest_enabled

hotspot_runtime:
17: OK

hotspot_gc:
17: OK

@zzambers
Copy link
Contributor Author

aarch64_linux

hotspot_serviceability:
17: OK

hotspot_runtime:
17: OK

@zzambers
Copy link
Contributor Author

x86-64_windows

hotspot_runtime:
17: OK

hotspot_serviceability:
17: OK

hotspot_gc:
17: OK

@zzambers
Copy link
Contributor Author

I have done testing on other platforms and updated exclude lists.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra testing @zzambers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants