pbTests: Allow use of default values for make-adopt-build-farm.sh #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build PRs blocking it are merged now, so I'll test this :-) |
sxa
force-pushed
the
vpcdetect
branch
3 times, most recently
from
b9b7a08
to
6a3e754
Compare
Willsparker
requested changes
Feb 24, 2021
There was a problem hiding this comment.
Otherwise, LGTM - I'm assuming this has already been put through VPC?
EDIT: The VPC runs you linked above failed, as did the most recent run(s) of VPC that are testing your branch (1072 and 1073). I can see the errors are unbounded variables, which I assume are fixed with the addition of :-} to the debug output?
sxa
force-pushed
the
vpcdetect
branch
3 times, most recently
from
b12a4cd
to
933180c
Compare
Signed-off-by: Stewart X Addison <[email protected]>
|
https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1078/OS=Ubuntu1804,label=vagrant/console has passed so taking this out of draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a clue if I've stripped too much out or not, but might as well give it a shot ... Now possible thanks to adoptium/temurin-build#2167 adoptium/temurin-build#2479 adoptium/temurin-build#2482 but requires adoptium/temurin-build#2478 but weill require adoptium/temurin-build#2478 to be merged before testing
Signed-off-by: Stewart X Addison [email protected]
Checklist