Autodetect boot JDK location based on playbook defaults

[sxa]

Draft PR to auto-set JDK_BOOT_DIR based on default locations symlinked by the ansible playbooks. This should remove the need to have JDKxx_BOOT_DIR definitions on the build machines in jenkins and reduce the number of times a boot JDK is downloaded dynamically during the builds

VPC run

Signed-off-by: Stewart X Addison [email protected]

[adoptopenjdk-github-bot]

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[karianna]

LGTM

[adoptopenjdk-github-bot]

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[adoptopenjdk-github-bot]

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[sxa]

Needs more work as it's causing issues in VPC with JDK8 builds using JDK7 to boot
Working build:

15:05:06 Detecting boot jdk for: jdk8u
15:05:06 Found build version: 8
15:05:06 Required boot JDK version: 7
15:05:06 /usr/local/gcc/bin/ccache
15:05:06 Boot jdk directory: /usr/lib/jvm/java-1.7.0-openjdk.x86_64:
15:05:07 BOOT JDK: java version "1.7.0_261"

New failing build:

14:17:03 Detecting boot jdk for: jdk8u
14:17:03 Found build version: 8
14:17:03 Required boot JDK version: 7
14:17:03 Downloading GA release of boot JDK version 7...
14:17:03 
14:17:03 gzip: stdin: unexpected end of file
14:17:03 tar: Child returned status 1
14:17:03 tar: Error is not recoverable: exiting now

[AdamBrousseau]

Could bootjdk location be added to the config files jdkX_pipeline_config.groovy?
I'm thinking if a machine does not use the default playbook locations and the preference is to not have to define the variable on the Jenkins node, then it may be nice to have the option available in the config file (Related #2132).

[karianna]

@sxa - Did you want to continue with this PR or are you happy to park it given our refactoring efforts?

[sxa]

@sxa - Did you want to continue with this PR or are you happy to park it given our refactoring efforts?

On my list for this week, but I don't believe this PR is part of the stuff that's going to be moved. This will make the build and infra a bit simpler, so I want it in :-)

[sxa]

Could bootjdk location be added to the config files jdkX_pipeline_config.groovy?

I think a default could reasonably be made there. My interest in particular is making sure that if someone is trying to debug locally on a machine (so not running via the playbooks) that these scripts are as self-sufficient as possible, but I certainly wouldn't be averse to having them in another location too

[sxa]

Not quite certain which VPC platforms are stable at the moment unfortunately so I've run two for this to be able to compare:

• https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1017/ (JDK15 - without this change)
• https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1018/ (JDK15 - with this change)

[sxa]

VPC - JDK15 JDK8

[sxa]

New vpc after further minor adjustments: JDK15 - JDK8

[sxa]

run tests

[M-Davies]

Indentations appear off after the removal of the following if block. Might be just GH's editor being funky with tabs however

# Any version above 8 (11 for now due to openjdk-build#1409
if [ "$JAVA_FEATURE_VERSION" -gt 11 ]; then

[sxa]

Indentations appear off after the removal of the following if block. Might be just GH's editor being funky with tabs however

# Any version above 8 (11 for now due to openjdk-build#1409
if [ "$JAVA_FEATURE_VERSION" -gt 11 ]; then

Can you be more specific with "off"? Looks ok to me

[sxa]

Oh hang on - you're talking about the AIX one specifically ...

[sxa]

OK I've put the conditional back in for now - adjusting it should probably be the scope of a separate PR

[M-Davies]

All of them actually. If you look at each file appears off after that if block has been removed. Mac for example:

[sxa]

Got stuck in rebase hell there for a bit. Not sure what was going on, anyway hopefully it's ok now and I'm running new VPCs a new vpc after further minor adjustments: JDK15 - JDK8

[gdams]

Happy for this to go in - I'd like to see someone break this function out into a commonplace though to avoid duplication at some point

[sxa]

Happy for this to go in - I'd like to see someone break this function out into a commonplace though to avoid duplication at some point

There a lot of cleaning up I'd like to do with these scripts but I'm focusing on usability for now. The directory that it selects is different for each platform which makes it more difficult to get advantages from unifying under a single function (unless we always installed into, day, /usr/local/java regardless of platform

[sxa]

Merging and I'll run a JDK17 pipeline (which failed last night due to the freemarker version issue) in order to verify and fix if required.