-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: Add changed_when fields to shell modules, in gcc roles #2424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make sure this has gone through a VPC run first without problems
Agreed- I haven't set it going just yet because we have 3 runs currently going on :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm this appears to be causing failures in ansible_lint
[EDIT: Probably not specific to the PR - raised https://github.com//issues/2426]
Linter is broken, as per your issue (#2426). The docker CentOS6 run seems happy :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on https://ci.adoptopenjdk.net/job/VagrantPlaybookCheck/1382 :-)
(I'm assuming you've verified that it does the right thing when it's already installed i.e. on the second run of the playbook)
Double checking that now :-) Thanks for running VPC |
Yep, it worked when I ran it twice. These roles now only report "ok" or "skipped", which is what we want :-) |
Ref: #2422
As per my comment in the referenced issue, these queries are not changing the machine state, so they shouldn't report
changed
.I prioritized these GCC roles, so they accurately reflect the new GCC-10 role from #2420.
Checklist