Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: Add changed_when fields to shell modules, in gcc roles #2424

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

Willsparker
Copy link
Contributor

Ref: #2422

As per my comment in the referenced issue, these queries are not changing the machine state, so they shouldn't report changed.

I prioritized these GCC roles, so they accurately reflect the new GCC-10 role from #2420.

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@Willsparker Willsparker added this to the 2022-01 (January) milestone Jan 10, 2022
@Willsparker Willsparker requested a review from sxa January 10, 2022 11:21
@Willsparker Willsparker self-assigned this Jan 10, 2022
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure this has gone through a VPC run first without problems

@Willsparker
Copy link
Contributor Author

Agreed- I haven't set it going just yet because we have 3 runs currently going on :-)

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm this appears to be causing failures in ansible_lint
[EDIT: Probably not specific to the PR - raised https://github.com//issues/2426]

@Willsparker
Copy link
Contributor Author

Willsparker commented Jan 10, 2022

Linter is broken, as per your issue (#2426). The docker CentOS6 run seems happy :-)

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on https://ci.adoptopenjdk.net/job/VagrantPlaybookCheck/1382 :-)

(I'm assuming you've verified that it does the right thing when it's already installed i.e. on the second run of the playbook)

@Willsparker
Copy link
Contributor Author

Double checking that now :-) Thanks for running VPC

@Willsparker
Copy link
Contributor Author

Yep, it worked when I ran it twice. These roles now only report "ok" or "skipped", which is what we want :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants